Improved AMSMessage creation by using memcpy (#105)#106
Merged
Conversation
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
koparasy
reviewed
Mar 13, 2025
koparasy
approved these changes
Mar 13, 2025
Member
koparasy
left a comment
koparasy
left a comment
There was a problem hiding this comment.
LGTM, after you fix failing tests I will merge it in.
Member
|
Tests failed cause of NFS issues on our clusters. I restarted them and they went through. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #105
I have added a caliper call to estimate the time spent doing construction of AMSMessage. I can remove it.
Based on a few tests, this optimization brings a
1.75-2xspeedup on the step measuring the time spent creating AMSMessage